Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary mut from variable #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cjpearce
Copy link

@cjpearce cjpearce commented May 4, 2020

Just removing an unnecessary mut from the dist_if_substitute variable, as it's common to avoid mut in rust where possible. This has a surprisingly large effect on performance:

before:

go: 1.768400
javascript: 3.54
rust: 2.069717745

after:

go: 1.757984
javascript: 3.347
rust: 1.415786823

Both tests were run on a Dell XPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant