Windows build problems (VC9 from Windows 7 SDK) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple problems in one go.
…t before declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Thanks for your great library. It's one of the most exciting things I've used this year, and solved a problem where I had to parse a browser PAC file inside PHP. The possibilities are huge with this extension, it works very well, and is easy to use.
I have posted the changes I had to make to get it to build on VC9, you might have better ways of doing it than me, but the latest MS compiler is stricter than before.
I built with the static spidermonkey from Mozilla, so the extension is on the large side (1.5M), but doesn't need another DLL.
Rob