Bail on preview file changes #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codykaup
added
release
|
📦 Package Size: 5448 KB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
+ Coverage 69.39% 69.40% +0.01%
==========================================
Files 202 202
Lines 7316 7319 +3
Branches 1276 1280 +4
==========================================
+ Hits 5077 5080 +3
Misses 2216 2216
Partials 23 23 ☔ View full report in Codecov by Sentry. |
jmhobbs
approved these changes
Jan 2, 2025
codykaup
added
minor
codykaup
deleted the
cody/cap-2599-turbosnap-exit-on-storybook-config-does-not-work-as-expected
branch
|
🚀 PR was released in |
chromatic-ci-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to make a change to
preview.jsand TurboSnap doesn't trigger a full rebuild (as seen with Vite projects). Instead, we want this to trigger a full rebuild to not miss anything.buildand thenbuild-storybook --stats-jsonchromatic trace .storybook/main.tsand notice the TurboSnap bail message outputs in the terminal (be sure to use the canary listed in this PR)npx chromatic trace .storybook/preview.tsxand you should see the same bail message but pointing topreview.tsx(again, with the canary from this PR)📦 Published PR as canary version:
11.23.0--canary.1133.12600702396.0✨ Test out this PR locally via: