Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rsbuild v0.1.7 support #1138

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Jan 9, 2025

Closes #1137
Closes CAP-2412

This PR does a couple things:

  1. Adds rsbuild v0.1.7 support
    • The cache directory was flattened so TurboSnap would fail to find the CSF globs
  2. Fixes our large debug log line
    • That log line made it real tough to see if the TurboSnap change worked or not so I went ahead and fixed it
📦 Published PR as canary version: 11.22.3--canary.1138.12695624063.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup codykaup self-assigned this Jan 9, 2025
@codykaup codykaup added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

📦 Package Size: 5448 KB

@codykaup codykaup requested a review from a team January 9, 2025 16:36
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.39%. Comparing base (c8530c9) to head (a2bbb87).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1138   +/-   ##
=======================================
  Coverage   69.38%   69.39%           
=======================================
  Files         202      202           
  Lines        7321     7322    +1     
  Branches     1278     1280    +2     
=======================================
+ Hits         5080     5081    +1     
  Misses       2218     2218           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codykaup codykaup added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit b802467 Jan 9, 2025
25 of 26 checks passed
@codykaup codykaup deleted the cody/cap-2627-turbosnap-doesnt-work-with-the-latest-version-of-storybook branch January 9, 2025 17:46
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.22.2 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TurboSnap doesn't work with the latest version of storybook-rsbuild
3 participants