Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Turbosnap metrics to New Relic #1141

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Log Turbosnap metrics to New Relic #1141

merged 1 commit into from
Jan 14, 2025

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Jan 14, 2025 •
edited by chromatic-ci-bot
Loading

We want to monitor if our lock file parsing is still helping with TurboSnap. This adds some quick metrics to help us figure that out.

📦 Published PR as canary version: 11.25.0--canary.1141.12776538036.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup codykaup self-assigned this Jan 14, 2025
@codykaup codykaup added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

📦 Package Size: 5448 KB

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (279132b) to head (bc2f641).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
node-src/tasks/upload.ts 78.57% 3 Missing ⚠️
node-src/lib/newRelic.ts 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
+ Coverage   69.44%   69.53%   +0.08%     
==========================================
  Files         202      203       +1     
  Lines        7335     7369      +34     
  Branches     1282     1288       +6     
==========================================
+ Hits         5094     5124      +30     
- Misses       2218     2222       +4     
  Partials       23       23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codykaup codykaup marked this pull request as ready for review January 14, 2025 20:52
@codykaup codykaup requested review from a team and ethriel3695 January 14, 2025 20:52
@codykaup codykaup added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit f349c8e Jan 14, 2025
27 of 28 checks passed
@codykaup codykaup deleted the cody/cap-2635-add-metrics-to-determine-if-lock-file-parsing-is-helping-or branch January 14, 2025 21:15
@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Jan 14, 2025
codykaup added a commit that referenced this pull request Jan 16, 2025
@codykaup
Revert "Merge pull request #1141 from chromaui/cody/cap-2635-add-metr…
6646a43 
…ics-to-determine-if-lock-file-parsing-is-helping-or"

This reverts commit f349c8e, reversing
changes made to 1ecc76c.
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.25.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethriel3695 ethriel3695 ethriel3695 approved these changes

@jmhobbs jmhobbs jmhobbs approved these changes

Assignees

@codykaup codykaup

Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codykaup @chromatic-ci-bot @jmhobbs @ethriel3695