Don't normalize package.json fields #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codykaup
added
release
|
📦 Package Size: 5448 KB |
codykaup
force-pushed
the
cody/cap-2409-cli-exits-silently-when-packagejson-version-field-does-not
branch
from
f235959 to
3710ea1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
+ Coverage 69.44% 70.05% +0.60%
==========================================
Files 202 202
Lines 7335 7336 +1
Branches 1284 1299 +15
==========================================
+ Hits 5094 5139 +45
+ Misses 2218 2174 -44
Partials 23 23 ☔ View full report in Codecov by Sentry. |
codykaup
force-pushed
the
cody/cap-2409-cli-exits-silently-when-packagejson-version-field-does-not
branch
from
3710ea1 to
e9d7fa8
Compare
jmhobbs
approved these changes
Jan 16, 2025
It does a bunch of stuff but it doesn't appear we use any of it (I could be wrong though). |
codykaup
deleted the
cody/cap-2409-cli-exits-silently-when-packagejson-version-field-does-not
branch
|
🚀 PR was released in |
chromatic-ci-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1123
This fixes a weird bug where an invalid semver string in the
versionfield of a user'spackage.jsoncauses the CLI to silently exit. Turns out, it comes from normalizing thepackage.jsonfile fromread-package-upandmeow. This disables that behavior to prevent this issue.📦 Published PR as canary version:
11.25.2--canary.1143.12912030314.0✨ Test out this PR locally via: