Directly execute build-archive-storybook if we can't resolve it

[tmeasday]

In the GitHub action, we cannot import peer dependencies (or anything really). However we should be able to npm exec <bin-command> inside the user's project dir, if the package is installed.

📦 Published PR as canary version: 10.9.3--canary.917.7834066638.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

[thafryer]

As an eventual follow-up, I'll note a ticket to add some playwright and cypress tests to CI. So, we know if anything breaks as early as possible.

[tmeasday]

@tevanoff I managed to get the action to run in the wrong dir and show the error here:

[tevanoff]

All worked in a few different test cases for me! 💯

[ghengeveld]

🚀 PR was released in v10.9.2 🚀

[shrink]

I think this change has caused some important errors to be swallowed. I was encountering an error that presented as follows:

Building your Storybook
    → Running command: npm exec build-archive-storybook --output-dir /tmp/chromatic--1880-VEzc3CPix51U --webpack-stats-json /tmp/chromatic--1880-VEzc3CPix51U
    → [*                   ]
✖ Failed to import `@chromatic-com/playwright`, is it installed in `package.json`?
    → Command failed: npm exec build-archive-storybook --output-dir /tmp/chromatic--1880-VEzc3CPix51U --webpack-stats-json /tmp/chromatic--1880-VEzc3CPix51U

ℹ To run `chromatic --playwright` you must have `@chromatic-com/playwright` installed.

So I spent a while debugging my dependencies and trying to find out why @chromatic-com/playwright wasn't available. Anyway, after a while I decided that the error message must be wrong and dug in further by running the npm exec build-archive-storybook command in my Workflow myself which led me to the real error:

Error: Chromatic archives directory cannot be found: /home/runner/work/_/_/test-results/chromatic-archives
Please make sure that you have run your E2E tests, or have set the CHROMATIC_ARCHIVE_LOCATION env var if the output directory for the tests is not in the standard location.

Looking at this change, there's this comment:

// If we tried to run the E2E package's bin directly (due to being in the action)
// and it failed, that means we couldn't find it. This probably means they haven't
// installed the right dependency or run from the right directory

I think that's probably the wrong logic because build-archive-storybook could fail to execute for many different reasons. I think the easiest fix would be to dump out the underlying error (so that there's a clue for someone encountering a different error) or I think the ideal fix would be to limit the missingDependency error to only cases where the dependency was missing.

[tmeasday]

Thanks for the investigation @shrink and that's a great point!