Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

Commit

Permalink
controller: workload csv typo asks for 80vcpus for docker
Browse files Browse the repository at this point in the history
This is probably not a real issue today, but...

Each of our sample workloads appears meant to request 80MB of persistent
storage.  Which is ignored anyway.  There is a typo for two docker workload
descriptions which sets the resource_id to #2 for the disk line instead of

Resource #2 is cpu, so technically the template is saying those docker
workloads should get 80 CPUs worth of resource allocation.  That's not
good.  Now really we don't account CPUs or create cpusets (that I'm aware
of anyway) yet for docker workloads.  And it may be that having read the
earlier line requesting 2 CPUs worth of resource, that the second request
is ignored.

So we're probably multiple times lucky.  Either way, let's just make
sure we don't rely on luck.
  • Loading branch information
Tim Pepper committed Apr 22, 2016
1 parent 13ff220 commit 3b0c09d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ciao-controller/tables/workload_resources.csv
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ eba04826-62a5-48bd-876f-9119667b1487, 4, 1024, 1024, 1
eba04826-62a5-48bd-876f-9119667b1487, 5, 1, 1, 1
ca957444-fa46-11e5-94f9-38607786d9ec, 2, 2, 2, 1
ca957444-fa46-11e5-94f9-38607786d9ec, 3, 128, 128, 1
ca957444-fa46-11e5-94f9-38607786d9ec, 2, 80, 80, 1
ca957444-fa46-11e5-94f9-38607786d9ec, 4, 80, 80, 1
ab68111c-03a6-11e6-87de-001320fb6e31, 2, 2, 2, 1
ab68111c-03a6-11e6-87de-001320fb6e31, 3, 128, 128, 1
ab68111c-03a6-11e6-87de-001320fb6e31, 2, 80, 80, 1
ab68111c-03a6-11e6-87de-001320fb6e31, 4, 80, 80, 1

0 comments on commit 3b0c09d

Please sign in to comment.