ciao-deploy: enable memory limits by default

[kaccardi]

Enable memory limit checking by launcher by default,
and only disable if --disable-limits is passed to ciao-deploy setup.

Fixes: #1539

Signed-off-by: Kristen Carlson Accardi [email protected]

[coveralls]

Coverage increased (+0.005%) to 65.743% when pulling 53ffe1d on kaccardi:topic/issue-1539 into f6b599e on ciao-project:master.

[rbradford]

@kaccardi see @markdryan's comment on #1539 "Let's only enable limits for memory for now. The concept of disk limits is currently broken, see #1541."

[coveralls]

Coverage increased (+0.005%) to 65.743% when pulling 3a1d6c0 on kaccardi:topic/issue-1539 into f6b599e on ciao-project:master.

[rbradford]

@kaccardi Thanks for the update. The changes in ciao-deploy lgtm. However do you know if we need to disable in singlevm.

Could you also update the commit message (i see you've updated the PR description already.)

[coveralls]

Coverage decreased (-0.005%) to 65.666% when pulling 8476826 on kaccardi:topic/issue-1539 into 9e6de96 on ciao-project:master.

[kaccardi]

@rbradford I confirmed you do not need to disable memory in single vm, so I removed that.

[markdryan]

I can't see how this has any effect. By default,

config.Configure.Launcher.MemoryLimit = false

When we supply --disable-limits it will still be false.

Should this be

if !clusterConf.DisableLimits {
    config.Configure.Launcher.MemoryLimit = true
}

[markdryan]

or simply

config.Configure.Launcher.MemoryLimit = !clusterConf.DisableLimits

[kaccardi]

I swear this was tested... but you are right, this doesn't do anything. I must have broken something when I was doing some quick adjustment. will fix, sorry.

[coveralls]

Coverage remained the same at 65.66% when pulling fc67855 on kaccardi:topic/issue-1539 into 3ea39a2 on ciao-project:master.