This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
[DONOTMERGE] networking: Add IPNetDeepCopy function
#451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrkz @mcastelino Would you guys mind amending the commit message with an explanation as to why this is needed ? |
|
@sameo the go network library lacks a deepcopy implementation for IP and IPNet. We were using the .Mask to implement deep copy. This implementation will replace the mask with a more efficient implementation. It may make sense to export this out of libsnnet to as it will be useful elsewhere in our code. |
|
@mrkz can we also test with IPv6 addresses also just to be safe. |
mrkz
changed the title
IPNetDeepCopy functionIPNetDeepCopy function
|
Needs rework for failing tests |
`IPNetDeepCopy` will create a full copy of a IPNet struct Signed-off-by: Simental Magana, Marcos <[email protected]>
previously `IP.Mask` was used to copy an IPNet struct, now that we provide a proper function to create IPNet copies we can make use of it and avoid Mask hacks. Signed-off-by: Simental Magana, Marcos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPNetDeepCopywill create a full copy of a IPNet structSigned-off-by: Simental Magana, Marcos [email protected]