This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
ciao-launcher: Fix unit test deadlocks #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in instance_test.go that waited for the instance loop to close down was incorrect. There was a possibility of deadlock if the instance loop was sending some stats down the overseer channel at the same time as the test was trying to shut down the instance. There is similar code in the overseer which actually shuts down the instance loop correctly. This commit simply ports the good overseer code over to instance_test.go. Partial fix for ciao-project#434 Signed-off-by: Mark Ryan <[email protected]>
markdryan
force-pushed
the
kaccardi/topic/storage
branch
from
073416b to
b764708
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in instance_test.go that waited for the instance loop to close
down was incorrect. There was a possibility of deadlock if the instance
loop was sending some stats down the overseer channel at the same time
as the test was trying to shut down the instance. There is similar code
in the overseer which actually shuts down the instance loop correctly.
This commit simply ports the good overseer code over to instance_test.go.
Partial fix for #434
Signed-off-by: Mark Ryan [email protected]