Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get stream destination info #19

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Conversation

gub-7
Copy link
Contributor

@gub-7 gub-7 commented Nov 24, 2024

No description provided.

Copy link
Owner

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it looks good 👍, just a couple small changes that I'd like to see before merging this

kick/__main__.py Outdated Show resolved Hide resolved
kick/client.py Outdated Show resolved Hide resolved
kick/http.py Outdated Show resolved Hide resolved
@gub-7 gub-7 force-pushed the get_stream_destination_info branch from b4b8259 to e1f1df1 Compare November 24, 2024 11:08
@gub-7
Copy link
Contributor Author

gub-7 commented Nov 25, 2024

Hold off on this and the other PRs for a bit i'm fixing some issues with the commit history

@cibere
Copy link
Owner

cibere commented Nov 25, 2024

Now that I think about it, I wonder if something like Client.fetch_stream_info is more appropriate

cibere
cibere previously requested changes Nov 25, 2024
kick/users.py Outdated Show resolved Hide resolved
kick/users.py Outdated Show resolved Hide resolved
@gub-7 gub-7 force-pushed the get_stream_destination_info branch from 2148906 to 2672c85 Compare November 30, 2024 01:33
@gub-7
Copy link
Contributor Author

gub-7 commented Nov 30, 2024

Addressed all your comments, this branch should be ready to go.

@cibere cibere dismissed their stale review November 30, 2024 01:53

changes have been made

@cibere cibere merged commit 2ba20ed into cibere:main Nov 30, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants