ksmbd-tools: mountd: check rpc_{lsarpc,samr}_init return value

While here, add some missing checks in rpc_samr_init(). Signed-off-by: Marios Makassikis <[email protected]> Signed-off-by: Namjae Jeon <[email protected]>
cifsd-team · Nov 11, 2022 · 68e8234 · 68e8234
1 parent 1ee5f7b
commit 68e8234
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/mountd/rpc.c b/mountd/rpc.c
@@ -743,8 +743,10 @@ int rpc_init(void)
 	if (!pipes_table)
 		return -ENOMEM;
 	g_rw_lock_init(&pipes_table_lock);
-	rpc_samr_init();
-	rpc_lsarpc_init();
+	if (rpc_samr_init())
+		return -ENOMEM;
+	if (rpc_lsarpc_init())
+		return -ENOMEM;
 	return 0;
 }
 

diff --git a/mountd/rpc_samr.c b/mountd/rpc_samr.c
@@ -1041,8 +1041,10 @@ int rpc_samr_init(void)
 		return -ENOMEM;
 
 	domain_name = g_ascii_strup(hostname, strlen(hostname));
-	rpc_samr_add_domain_entry(domain_name);
-	rpc_samr_add_domain_entry("Builtin");
+	if (rpc_samr_add_domain_entry(domain_name))
+		return -ENOMEM;
+	if (rpc_samr_add_domain_entry("Builtin"))
+		return -ENOMEM;
 	g_rw_lock_init(&ch_table_lock);
 	return 0;
 }