ignore trailing slash in share path #611
Conversation
mgmt/share_config.c
Outdated
| share->path_sz = strlen(share->path); | ||
| if (share->path_sz > 1 && share->path[share->path_sz - 1] == '/') |
There was a problem hiding this comment.
@bonifaido Thanks for your patch:) BTW, if share pathname is "/home/me/Share//" or "/home/me/Share////", there no problem with this patch ?
There was a problem hiding this comment.
Sorry for the late reply.
Most probably there is a problem in those cases, is there a function available to do this in the module or in the kernel?
There was a problem hiding this comment.
there is no function for this. You need to add simple while loop like the following one. I didn't test it. can you check it ?
while (share->path_sz > 1 && share->path[share->path_sz - 1] == '/') {
share->path[share->path_sz - 1] = '\0';
share->path_sz--;
}
There was a problem hiding this comment.
And please make the patch using git command to add signoff-by tag and your real name and mail address.
and need to add prefix(ksmbd: ) and patch description to the patch.
See other patches.
namjaejeon@ef5e170
There was a problem hiding this comment.
Let me know if you are busy. I need to apply this patch today or till tomorrow.
There was a problem hiding this comment.
I have incorporated the requested change, tested on my pizero 2w, with iOS VLC and Android VLC, works fine! Thank you!
There was a problem hiding this comment.
Thanks for your test:) I have optimized the patch and apply it to next branch.(namjaejeon@3172144)
If there is a problem, Let me know. Thanks.
There was a problem hiding this comment.
Thank you very much! What is the target kernel release for this patch?
There was a problem hiding this comment.
I will add stable tag to the patch. This patch will be applied to stable kernels(5.15, 6.1, 6.6, 6.9) and 6.10-rc1.
Signed-off-by: Nandor Kracser <[email protected]>
Trailing slashes in share paths (like:
/home/me/Share/) caused permission issues with shares for clients on iOS and on Android TV for me, but otherwise they work fine with plain old Samba.Might not be the best place to handle this, I'm open for suggestions! :)