conntrack: replace std::mutex with Thread::MutexBasicLockable #1095
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream Envoy linting prevents usages of `std::mutex` in favor of `Thread::MutexBasicLockable`. See https://github.com/envoyproxy/envoy/blob/main/tools/code_format/check_format.py#L605-L610 ``` report_error( "Don't use <mutex> or <condition_variable*>, switch to " "Thread::MutexBasicLockable in source/common/common/thread.h") ``` This error occurred while trying to cleanup the imports - and therefore adding the direct dependency to `<mutex>`. See cilium#1089 Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
force-pushed
the
pr/mhofstetter/mutex-threadlib
branch
from
0430df5 to
626eafd
Compare
jrajahalme
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Envoy linting prevents usages of
std::mutexin favor ofThread::MutexBasicLockable.This error occurred while trying to cleanup the imports - and therefore adding the direct dependency to
<mutex>.See https://github.com/envoyproxy/envoy/blob/main/tools/code_format/check_format.py#L605-L610
See #1089