bpf_metadata: don't restore local address for L7LB #1141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the local address always gets restored. But this functionality is only used to restore the original destination address that then is used by the original destination discovery service. But this is only used in the E/W ingress/egress cases for Cilium policy enforcement, but not for the L7 loadbalancing cases (N/S & E/W). In these cases, the related log message is confusing. Therefore, this commit changes the logic to prevent restoration in case of L7 LB. Signed-off-by: Marco Hofstetter <[email protected]>
|
Also required by Cilium functionality. I was irritated by the additional restoration within |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the local address always gets restored.
But this functionality is only used to restore the original destination address that then is used by the original destination discovery service.
But this is only used in the E/W ingress/egress cases for Cilium policy enforcement, but not for the L7 loadbalancing cases (N/S & E/W). In these cases, the related log message is confusing.
Therefore, this commit changes the logic to prevent restoration in case of L7 LB.
Example
In case of N/S L7 LB where we see an unnecessary restoration (
127.0.0.1:16898(Ingress listener with dynamic port) ->172.19.255.1:80(Node IP where the Ingress call was sent to). This doesn't make sense and is confusing.