-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows-curses dependency for Windows #1134
base: master
Are you sure you want to change the base?
Conversation
@biozz Thanks for this - I don't use windows regularly either, and even if I did I think the best solution is to include a basic windows test in the CI. In order to achieve this, I would suggest to:
I've had a look at the travis config of circus and it looks rather minimal. |
@ltalirz yes, sure thing. I was also checking out travis docs and it has multi-os support including windows. Personally I don't have any preference on the ci as long as it works and not too complicated to setup. Tagging @k4nar for an opinion. |
I see, wasn't even aware of that. 20 minutes was a bit too optimistic but looks like I'm done. Will make a PR. |
I tried to add a Windows CI via AppVeyor a few years ago, without any success. If you manage to do it that would be awesome! |
It's already done :-) However, the tests are still skipped on windows, i.e. it remains to be seen whether there are still tricks to be played. @biozz is kindly working on it |
363e667
to
0ca6132
Compare
0ca6132
to
3c67f16
Compare
I am still trying to setup windows environment: virtualbox with windows server 2019 and things break where you don't expect. So that's why it takes quite a lot of time. UPD: I couldn't get it to work, so for the time being this will have to wait for someone with windows experience to complete... |
Closes #1100.
Disclaimer: I am using macOS and have difficulties setting up Windows environment to test this feature, so I would like to have some feedback from Windows users out there, pinging @ltalirz.