best practice improvements for how file protocol is handled before in…

…voking selenium; adding caching for both windows/macos deps
cisagov · Aug 1, 2024 · bf49bad · bf49bad
1 parent a3f428f
commit bf49bad
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 34 deletions.
diff --git a/.github/actions/setup-dependencies-macos/action.yml b/.github/actions/setup-dependencies-macos/action.yml
@@ -10,13 +10,6 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - name: Cache packages
-      uses: actions/cache@v3
-      with: 
-        path: ~/.cache/pip
-        key: ${{ runner.os }}-pip=${{ hashFiles("**/requirements.txt") }}
-        restore-keys: ${{ runner.os }}-pip-
-
     - name: Setup virtualenv
       shell: bash
       run: |

diff --git a/.github/actions/setup-dependencies-windows/action.yml b/.github/actions/setup-dependencies-windows/action.yml
@@ -10,13 +10,6 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - name: Cache packages
-      uses: actions/cache@v3
-      with: 
-        path: ~/.cache/pip
-        key: ${{ runner.os }}-pip=${{ hashFiles("**/requirements.txt") }}
-        restore-keys: ${{ runner.os }}-pip-
-
     - name: Setup virtualenv
       shell: powershell
       run: |

diff --git a/.github/actions/setup-python/action.yml b/.github/actions/setup-python/action.yml
diff --git a/.github/workflows/run_smoke_test.yml b/.github/workflows/run_smoke_test.yml
@@ -31,9 +31,10 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: ./.github/actions/setup-python
-        with:
+        uses: actions/setup-python@v5
+        with: 
           python-version: ${{ matrix.python-version }}
+          cache: "pip"
           cache-dependency-path: "requirements.txt"
 
       - name: Setup Dependencies (Windows)