Ensure Each Control Is Included in the Reports

[adhilto]

💡 Summary

One basic form of error handling is to ensure that each control is included in the report.

Motivation and context

Rego bugs can sometimes be silent and cause a check to be omitted entirely. Unless we include an explicit check for this, it's very hard to even realize something went wrong in those cases.

Implementation notes

First, we need to ensure that each control has a Rego check. The following are missing:

• GWS.GMAIL.3.2v0.1
• GWS.GMAIL.10.2v0.1
• GWS.GMAIL.15.2v0.1
• GWS.GMAIL.16.2v0.1
• GWS.GMAIL.18.2v0.1
• GWS.GMAIL.18.3v0.1
• GWS.GMAIL.19.2v0.1
• GWS.GMAIL.19.3v0.1
• GWS.GMAIL.19.4v0.1

It just so happens that Gmail is the only baseline with this problem right now, but this issue could show up for any of the products.

Second, we need to modify the reporter to warn the user of missing output. There are two pieces to this:

• A warning printed to the terminal
• A warning included in the report

This is what that looks like on ScubaGear.

The rego_json_to_html function is the probably the most natural place to add this check.

Acceptance criteria

• Each control has a Rego check
• The check for missing output has been added to the Reporter