Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Each Control Is Included in the Reports #158

Closed
wants to merge 7 commits into from
Closed

Ensure Each Control Is Included in the Reports #158

wants to merge 7 commits into from

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Jan 24, 2024

🗣 Description

  • Modify the report to check for missing controls and warn the user
  • Add missing Rego checks for Gmail

💭 Motivation and context

Closes #157.

📷 Screenshots (if appropriate)

image
image

🧪 Testing

Note that I did not add the missing checks for group 19, "Attachment Compliance Filtering." That is because that group is being deleted by #156. In the meantime, that means you can run ScubaGoggles and see the new error handling in practice. Once both PRs are merged to main, the warnings will go away.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added bug This issue or pull request addresses broken functionality Gmail enhancement labels Jan 24, 2024
@adhilto adhilto requested review from amart241 and snarve January 24, 2024 00:31
@adhilto adhilto self-assigned this Jan 24, 2024
@adhilto adhilto linked an issue Jan 24, 2024 that may be closed by this pull request
Ensure Each Control Is Included in the Reports #157
Closed
13 tasks
adhilto added a commit that referenced this pull request Jan 25, 2024
@adhilto
Merge latest changes from #158, Ensure Each Control Is Included in the
7228bad 
Reports
@adhilto
Copy link
Collaborator Author

adhilto commented Jan 25, 2024

Creating another PR that includes this feature enhancement plus more.

@adhilto adhilto closed this Jan 25, 2024
LaurenBassett pushed a commit that referenced this pull request Feb 7, 2024
@adhilto
Enhance Error handling (#163)
56b1890 
* Implement warning for missing output

* Add missing reo spf check

* Add rego check for 10.2

* Add rego check for 15.2

* Add rego check for 16.2

* Add missing rego checks for group 18

* Broke up the run_reporter function to satisfy linter

* Initial commit of error handling code

* Merge latest changes from main

* Fix bad merge

* Simplify Tenant Metadata (#152)

* Simplify tenant metadata section and correct groups bug

* Remove scope that is no longer needed

* Remove unneeded OAUTH scope from readme

* Merge latest changes from #158, Ensure Each Control Is Included in the
Reports

* Fix bad merge

* Correct gmail bug, forgot to preface the dns function calls with self

* Refactor long lines

* Broke out error handling code into separate functions

* correct error with f string

* Add special case prereqs to rego files

* Modify groups prereqs

* Correct typo in reports API reference

* If prereqs not defined, assume dependence on reports api

* Fix error in provider from merge

* Add missing tests for gws 18

* Fix other regressions caused by merge

* Make the linter happy

* Refactor long lines

* Fix groups API reference links

* Refactor services object to a state variable

* Make customer_id and dnsclient state variables

* Ensure the domains() API is called only once

* Changes to satisfy the linter

* Convert API reference to enums

* Correct URL bugs

* Add documentation

* Rename api_reference to types
@adhilto adhilto deleted the 157-ensure-all-controls-present branch February 16, 2024 18:50
@adhilto adhilto added this to the TBD 0.2 Milestone milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amart241 amart241 Awaiting requested review from amart241

@snarve snarve Awaiting requested review from snarve

Assignees

@adhilto adhilto

Labels
bug This issue or pull request addresses broken functionality enhancement Gmail
Projects
None yet
Milestone
Barracuda
Development

Successfully merging this pull request may close these issues.

Ensure Each Control Is Included in the Reports
1 participant
@adhilto