Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template + CONTRIBUTING.md and update gitignore #115

Merged
merged 6 commits into from
Dec 15, 2023

Conversation

buidav
Copy link
Collaborator

@buidav buidav commented Dec 14, 2023

🗣 Description

  • Add back ignoring various out report files to the .gitignore but add an exception to the sample-report.
  • Add a CONTRIBUTING.MD and an updated PR template.
  • Tiny fix for a broken link in the README.
  • Update pylint to lint in the same scenarios and the rego linter.

💭 Motivation and context

To add and fix various issues found in misc files

🧪 Testing

Clicked on the various links throughout the updated files to see if they worked.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@buidav buidav added this to the Backlog milestone Dec 14, 2023
@buidav buidav self-assigned this Dec 14, 2023
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@buidav buidav merged commit ea2329f into main Dec 15, 2023
4 checks passed
@buidav buidav deleted the repo-quality-modifications branch December 15, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants