Code

Refactor All Rego#132

Code

Closed

adhilto wants to merge 59 commits intomaincisagov/ScubaGoggles:mainfrom refactor-rego-calendarcisagov/ScubaGoggles:refactor-rego-calendarCopy head branch name to clipboard

+3,550-4,119

Commits

Commits on Dec 27, 2023

• Refactor long lines; refactor GetTopLevelOU function

  adhilto

  committed
  4398e9e

  Copy full SHA for 4398e9e

• Unify comment style

  adhilto

  committed
  8640cfd

  Copy full SHA for 8640cfd

• Remove 'no domain' helper rules

  adhilto

  committed
  a339a4a

  Copy full SHA for a339a4a

• Change ServiceName to SettingName

  adhilto

  committed
  536b3c4

  Copy full SHA for 536b3c4

• Refactor test cases

  adhilto

  committed
  94cdb4d

  Copy full SHA for 94cdb4d

• Change lists to sets where possible

  adhilto

  committed
  d61caee

  Copy full SHA for d61caee

Commits on Dec 28, 2023

• Chat change to for in syntax

  adhilto

  committed
  ab78f65

  Copy full SHA for ab78f65

• Chat change to rule contains syntax

  adhilto

  committed
  57e3c05

  Copy full SHA for 57e3c05

• Refactor GetTopLevelOU function

  adhilto

  committed
  d6ac726

  Copy full SHA for d6ac726

• Change lists to sets where possible chat

  adhilto

  committed
  24cf819

  Copy full SHA for 24cf819

• Remove trailing whitespace

  adhilto

  committed
  48b686a

  Copy full SHA for 48b686a

• Change ServiceName to SettingName

  adhilto

  committed
  6c7d27e

  Copy full SHA for 6c7d27e

• Standardize comment syntax chat

  adhilto

  committed
  39b372a

  Copy full SHA for 39b372a

• Refactor chat unit tests

  adhilto

  committed
  3090931

  Copy full SHA for 3090931

• Change to for in syntax

  adhilto

  committed
  c43eedc

  Copy full SHA for c43eedc

• Change to rule contains syntax classroom

  adhilto

  committed
  25823ad

  Copy full SHA for 25823ad

• Change ServiceName to SettingName

  adhilto

  committed
  0385689

  Copy full SHA for 0385689

• Classroom change lists to sets where possible

  adhilto

  committed
  7810a05

  Copy full SHA for 7810a05

• Classroom standardize comments

  adhilto

  committed
  9ca6789

  Copy full SHA for 9ca6789

• Refactor GetTopLevelOU function Classroom

  adhilto

  committed
  6d03bc4

  Copy full SHA for 6d03bc4

• Refactor Classroom unit tests

  adhilto

  committed
  439153c

  Copy full SHA for 439153c

• Remove stray blank lines classroom

  adhilto

  committed
  9edcb7d

  Copy full SHA for 9edcb7d

• Refactor common functions Drive

  adhilto

  committed
  75727b3

  Copy full SHA for 75727b3

• Drive change to some in syntax

  adhilto

  committed
  d548ecd

  Copy full SHA for d548ecd

• Remove trailing whitespace

  adhilto

  committed
  5436193

  Copy full SHA for 5436193

• Remove more trailing whitespace

  adhilto

  committed
  499489e

  Copy full SHA for 499489e

• Change to rule contains syntax Drive

  adhilto

  committed
  ee6a3d3

  Copy full SHA for ee6a3d3

• Refactor long lines Drive

  adhilto

  committed
  3fd46e6

  Copy full SHA for 3fd46e6

• Drive standardize comments

  adhilto

  committed
  cbb38b8

  Copy full SHA for cbb38b8

• Refactor Drive unit tests

  adhilto

  committed
  93180d6

  Copy full SHA for 93180d6

• Refactor drive 2 long lines

  adhilto

  committed
  767f7f1

  Copy full SHA for 767f7f1

• Refactor groups unit tests

  adhilto

  committed
  48ae729

  Copy full SHA for 48ae729

Commits on Dec 30, 2023

• Groups standardize comments

  adhilto

  committed
  7984018

  Copy full SHA for 7984018

• Rego refactor meet

  adhilto

  committed
  b9bfb6a

  Copy full SHA for b9bfb6a

• Refactor 'or' Drive

  adhilto

  committed
  c36dd14

  Copy full SHA for c36dd14

• Refactor sites rego

  adhilto

  committed
  7a22b18

  Copy full SHA for 7a22b18

• Refactor utils rego

  adhilto

  committed
  02ef450

  Copy full SHA for 02ef450

• Move OUsWithEvents rule to the utils file

  adhilto

  committed
  99ec445

  Copy full SHA for 99ec445

• Calendar fill in topLevelOU in test cases with multiple OU as it cannot be blank in those cases

  adhilto

  committed
  f848ca3

  Copy full SHA for f848ca3

Commits on Dec 31, 2023

• Chat fill in empty topLevelOU in test cases where needed

  adhilto

  committed
  23411c3

  Copy full SHA for 23411c3

• Classroom fill in empty topLevelOU in test cases where needed

  adhilto

  committed
  40912b1

  Copy full SHA for 40912b1

• Drive unit tests fill in topLevelOU where required

  adhilto

  committed
  c9c10db

  Copy full SHA for c9c10db

• Gmail test cases add topLevelOU when needed

  adhilto

  committed
  46e77de

  Copy full SHA for 46e77de

• groups test cases add topLevelOU when needed

  adhilto

  committed
  98b12dd

  Copy full SHA for 98b12dd

• Meet test cases add topLevelOU when needed

  adhilto

  committed
  35e61dc

  Copy full SHA for 35e61dc

• Move TopLevelOU rule to utils file

  adhilto

  committed
  1a11058

  Copy full SHA for 1a11058

• Remove print statements

  adhilto

  committed
  363e61d

  Copy full SHA for 363e61d

• Move GetLastEvent function to utils file

  adhilto

  committed
  b99e889

  Copy full SHA for b99e889

Commits on Jan 2, 2024

• Moved all shared rego code to the utils file

  adhilto

  committed
  2b814b0

  Copy full SHA for 2b814b0

• Import utils package instead of individual rules

  adhilto

  committed
  e531c48

  Copy full SHA for e531c48

• push unsaved change

  adhilto

  committed
  906d767

  Copy full SHA for 906d767

Commits on Jan 3, 2024

• Remove duplicates from list

  adhilto

  committed
  7fa34f7

  Copy full SHA for 7fa34f7

• Change SettingChangeEvents back to filter by log name for efficiency

  adhilto

  committed
  bf1fc5f

  Copy full SHA for bf1fc5f

• Refactor groups 7

  adhilto

  committed
  260b199

  Copy full SHA for 260b199

• Ensure test names are unique

  adhilto

  committed
  224b0c5

  Copy full SHA for 224b0c5

• Add regal config file

  adhilto

  committed
  b36a237

  Copy full SHA for b36a237

• Add github workflow for regal

  adhilto

  committed
  d194196

  Copy full SHA for d194196

• Add missing ifs

  adhilto

  committed
  ef10861

  Copy full SHA for ef10861

Commits on Jan 8, 2024

• Bump the version of the regal exe

  adhilto

  committed
  e33872b

  Copy full SHA for e33872b