Wording Changes for Calendar Baseline per Issue 135 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcomeau
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Minor suggested edits. Please resend when ready and will review and then tag in @mitchelbaker-cisa
baselines/Google Calendar Minimum Viable Secure Configuration Baseline v0.1.md
Outdated
Show resolved
Hide resolved
baselines/Google Calendar Minimum Viable Secure Configuration Baseline v0.1.md
Outdated
Show resolved
Hide resolved
baselines/Google Calendar Minimum Viable Secure Configuration Baseline v0.1.md
Outdated
Show resolved
Hide resolved
…Baseline v0.1.md Co-authored-by: Thomas Comeau (MITRE) <[email protected]>
…Baseline v0.1.md Co-authored-by: Thomas Comeau (MITRE) <[email protected]>
…Baseline v0.1.md Co-authored-by: Thomas Comeau (MITRE) <[email protected]>
tmcomeau
approved these changes
Jan 5, 2024
jkaufman-mitre
changed the title
|
@jkaufman-mitre The changes here are highly related to and might even conflict with #134. Would you be open to closing this PR and making these changes all within #134 instead? Should be simple enough to repeat the changes over there. Otherwise I'll recommend marking this PR as blocked until #134 is complete. I can help deal with any merge conflict that arise if we take that route. |
jkaufman-mitre
added
the
blocked
|
@adhilto is this one no longer blocked based on your changes? |
|
I want to keep this one blocked until #134 is complete.
…________________________________
From: Lauren Bassett ***@***.***>
Sent: Tuesday, January 16, 2024 11:52:38 AM
To: cisagov/ScubaGoggles ***@***.***>
Cc: Hilton, Alden Douglas ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [cisagov/ScubaGoggles] Wording Changes for Calendar Baseline per Issue 135 (PR #136)
@adhilto<https://github.com/adhilto> is this one no longer blocked based on your changes?
—
Reply to this email directly, view it on GitHub<#136 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZKCJL2LJNDGHR5E2ZAGZUDYO3LANAVCNFSM6AAAAABBORN7Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGQYTEMBYGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
adhilto
removed
the
blocked
adhilto
approved these changes
Jan 17, 2024
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed wording to the Calendar baseline in 4.1, 3.1, and 1.1. This PR addresses the comments in issue 135.
Fixes #135