Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Policy Groups 22, 19, 18, and 12 andPolicy 15.2 from Gmail Baseline per Issue 137 #138

Merged
merged 8 commits into from
Jan 17, 2024

Conversation

jkaufman-mitre
Copy link
Collaborator

@jkaufman-mitre jkaufman-mitre commented Jan 5, 2024

Based on the comments in issue #137, the following policies have been removed from the baseline:

  • Policy Group 22
  • Policy Group 19
  • Policy Group 18
  • GMAIL.15.2v0.1
  • Policy Group 12

The remaining affected policies have been renumbered.

Fixes #137

@jkaufman-mitre
Copy link
Collaborator Author

Fixed the drift rules file. This PR Fixes #137

Copy link
Collaborator

@tmcomeau tmcomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the table in the introduction for traceability.

@jkaufman-mitre
Copy link
Collaborator Author

Fixed Table of Contents at beginning.

Copy link
Contributor

@LaurenBassett LaurenBassett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like the tests have been updated.

@jkaufman-mitre jkaufman-mitre changed the title Addresses comments in issue 137 Removed Policy Groups 22, 19, 18, and 12 andPolicy 15.2 from Gmail Baseline per Issue 137 Jan 8, 2024
@adhilto adhilto added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jan 9, 2024
@adhilto
Copy link
Collaborator

adhilto commented Jan 9, 2024

Marking as blocked until #132 is complete. When that is done I can make the needed code changes here.

@adhilto adhilto removed the request for review from buidav January 9, 2024 00:25
@adhilto
Copy link
Collaborator

adhilto commented Jan 15, 2024

@LaurenBassett, I've made the needed Rego changes in this branch. Could you review my code changes? Note that because of how I merged the latest from main into here, it's showing a ton of changes. To see just my changes, under the "Files changed" tab, you can select "Changes from all commits" and change it to just my commit, "Remove deleted controls from the rego" (cb6db95).

EDIT: actually David helped me clean up the PR, it should now only be showing the relevant changes.

@adhilto adhilto removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jan 15, 2024
@adhilto adhilto mentioned this pull request Jan 16, 2024
@buidav buidav changed the base branch from main to 124-feedback-no-guifront-end-availability-solution January 16, 2024 00:52
@buidav buidav changed the base branch from 124-feedback-no-guifront-end-availability-solution to main January 16, 2024 00:52
@adhilto adhilto changed the base branch from main to dns-refactor January 16, 2024 00:57
@adhilto adhilto changed the base branch from dns-refactor to main January 16, 2024 00:57
@LaurenBassett LaurenBassett merged commit d318a33 into main Jan 17, 2024
5 checks passed
@LaurenBassett LaurenBassett deleted the gmail-changes-1 branch January 17, 2024 18:19
@adhilto adhilto added this to the TBD 0.2 Milestone milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gmail Baseline Changes
4 participants