-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Policy Groups 22, 19, 18, and 12 andPolicy 15.2 from Gmail Baseline per Issue 137 #138
Conversation
Fixed the drift rules file. This PR Fixes #137 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check the table in the introduction for traceability.
Fixed Table of Contents at beginning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like the tests have been updated.
Marking as blocked until #132 is complete. When that is done I can make the needed code changes here. |
@LaurenBassett, I've made the needed Rego changes in this branch. Could you review my code changes? Note that because of how I merged the latest from main into here, it's showing a ton of changes. To see just my changes, under the "Files changed" tab, you can select "Changes from all commits" and change it to just my commit, "Remove deleted controls from the rego" (cb6db95). EDIT: actually David helped me clean up the PR, it should now only be showing the relevant changes. |
Based on the comments in issue #137, the following policies have been removed from the baseline:
The remaining affected policies have been renumbered.
Fixes #137