Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct DNS False Negatives #160

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Correct DNS False Negatives #160

merged 1 commit into from
Jan 29, 2024

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Jan 24, 2024

🗣 Description

Corrected the bug that showed all DNS related checks as passing when the DNS functions failed.

💭 Motivation and context

Closes #147.

🧪 Testing

  • Updated Rego test cases.
  • Temporarily added exception (x/0) to the top of query function of the RobustDNSClient to simulate DNS failures

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added the bug This issue or pull request addresses broken functionality label Jan 24, 2024
@adhilto adhilto requested review from rgbrow1949 and snarve January 24, 2024 22:21
@adhilto adhilto self-assigned this Jan 24, 2024
@adhilto adhilto linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link
Collaborator

@rgbrow1949 rgbrow1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an exception to the query function and ran over gmail on main and this branch. Main reported no issues, this branch correctly showed issues in 2, 3, and 4. Approved.

@buidav buidav self-requested a review January 29, 2024 20:31
@buidav buidav merged commit ec23054 into main Jan 29, 2024
6 checks passed
@buidav buidav deleted the 147-dns-false-negatives branch January 30, 2024 02:32
@adhilto adhilto added this to the TBD 0.2 Milestone milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS False Negatives
3 participants