-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drive_Docs Changes to 1.6 and 6.1 #311
Conversation
baselines/Google Drive and Docs Minimum Viable Secure Configuration Baseline v0.2.md
Outdated
Show resolved
Hide resolved
baselines/Google Drive and Docs Minimum Viable Secure Configuration Baseline v0.2.md
Outdated
Show resolved
Hide resolved
Added the changes to DRIVEDOCS.3.1v0.2 into this PR. Fixes #313 |
@jkaufman-mitre with regard to #313, please also:
|
@adhilto Just addressed your changes. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes. A few more comments:
baselines/Google Drive and Docs Minimum Viable Secure Configuration Baseline v0.2.md
Outdated
Show resolved
Hide resolved
baselines/Google Drive and Docs Minimum Viable Secure Configuration Baseline v0.2.md
Outdated
Show resolved
Hide resolved
I feel like this is worded vaguely, and there could be a better way to explain what the benefits of the setting entail. |
I updated the rationale statement for 3.1. Requesting review |
baselines/Google Drive and Docs Minimum Viable Secure Configuration Baseline v0.2.md
Outdated
Show resolved
Hide resolved
…ation Baseline v0.2.md Co-authored-by: Alden Hilton <[email protected]>
…ation Baseline v0.2.md Co-authored-by: Alden Hilton <[email protected]>
b7cc30d
to
5830660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Baseline looks good and I've implemented the needed changes in the Rego. Just one minor comment about the drift rule, but I'm going to go ahead and approve.
Co-authored-by: Alden Hilton <[email protected]>
🗣 Description
The following changes were made to the Drive_Docs baselines:
💭 Motivation and context
Closes #142.
Closes #289.
Closes #302.
Closes #313.
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist