Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove synchronize type from smoke test #367

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

mitchelbaker-cisa
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa commented Aug 28, 2024

🗣 Description

Removes the "synchronize" type from the smoke test. Update the smoke test workflow so it only runs when a PR is opened/reopened, if a review is added to a PR, and when a commit is added to main.

Resolves #366

🧪 Testing

  • Add a test commit to this PR, the smoke test workflow should not run again.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@mitchelbaker-cisa mitchelbaker-cisa added the bug This issue or pull request addresses broken functionality label Aug 28, 2024
@mitchelbaker-cisa mitchelbaker-cisa self-assigned this Aug 28, 2024
@adhilto adhilto merged commit aab307d into main Aug 28, 2024
8 of 12 checks passed
@adhilto adhilto deleted the 366-fix-smoke-test-trigger branch August 28, 2024 19:32
@adhilto adhilto added this to the Coast milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix how smoke test is triggered
3 participants