Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement data processing policy for common controls #485

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

mitchelbaker-cisa
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa commented Oct 30, 2024

🗣 Description

Implement rego for "Data SHALL be processed in the region selected for data at rest." common controls policy 15.2. This can be found under Data -> Compliance -> Data Regions -> Data Processing in the admin console.

💭 Motivation and context

Closes #444

🧪 Testing

Tested manually with the setting checked/unchecked for only root OU, overridden for sub-level OUs, only groups, and a combination of OUs and groups.

Run unit tests with

cd ./Testing
python ./run_unit_tests.py -b commoncontrols

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.
  • Confirm default setting.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@mitchelbaker-cisa mitchelbaker-cisa added this to the Driftwood milestone Oct 30, 2024
@mitchelbaker-cisa mitchelbaker-cisa self-assigned this Oct 30, 2024
@mitchelbaker-cisa mitchelbaker-cisa changed the base branch from main to driftwood October 30, 2024 01:43
@mitchelbaker-cisa mitchelbaker-cisa force-pushed the 444-implement-data-processing-policy branch from d2d1e95 to e1e16de Compare October 30, 2024 01:46
@adhilto adhilto changed the base branch from driftwood to main October 30, 2024 19:47
@buidav
Copy link
Collaborator

buidav commented Oct 31, 2024

  • Confirm default setting. Do we want to confirm it in this pull request or a later time?

@mitchelbaker-cisa
Copy link
Collaborator Author

Default setting is set to unchecked, commit added to fix. Merging into main.

@mitchelbaker-cisa mitchelbaker-cisa merged commit 2b9a8bc into main Oct 31, 2024
1 check passed
@mitchelbaker-cisa mitchelbaker-cisa deleted the 444-implement-data-processing-policy branch October 31, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement code for new data processing Common Controls policy
3 participants