Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Common Controls 11.2 to Policy Group 10 #487

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

mdueltgen
Copy link
Collaborator

@mdueltgen mdueltgen commented Oct 30, 2024

🗣 Description

Common Controls Policy 11.2 will be moved into Policy Group 10 since 11.2 does not related to Google Marketplace, but rather API access.

💭 Motivation and context

Closes #318

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just one small change, don't forget to move the "Control access to less secure apps" resource from 11 to 10

@mdueltgen mdueltgen requested a review from adhilto October 31, 2024 14:50
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I just pushed the needed code changes to this branch. @mdueltgen if you need to make more updates to this PR, I recommend pulling first so you have the changes locally. @buidav please review my code changes as well when you look at Max's changes.

@buidav buidav merged commit 2cbbfa2 into main Oct 31, 2024
11 checks passed
@buidav buidav deleted the 318-moving-commoncontrols112v02-into-policy-group-10 branch October 31, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving COMMONCONTROLS.11.2v0.2 into Policy Group 10
3 participants