Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy API: Use "General Availability" (GA) Release URL #535

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Dec 20, 2024

🗣 Description

Changed the URL for the Policy API from

https://cloudidentity.googleapis.com/v1beta1/policies (beta release)
to
https://cloudidentity.googleapis.com/v1/policies

Closes #518

🧪 Testing

Run ScubaGoggles with the new URL. Works as expected, with results returned by the Policy API.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev linked an issue Dec 20, 2024 that may be closed by this pull request
1 task
@adhilto adhilto added this to the Driftwood milestone Dec 20, 2024
@adhilto adhilto self-requested a review December 20, 2024 14:51
@rlxdev rlxdev force-pushed the 518-policy-api-GA-url branch from d5030a6 to 864469b Compare December 20, 2024 20:10
@adhilto adhilto requested a review from buidav January 8, 2025 18:37
@buidav buidav merged commit 8715985 into main Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the policy API URL
3 participants