generated from cisagov/ScubaGear
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save parameters to json file #551
Open
aormu
wants to merge
2
commits into
519-policy-api-updates
Choose a base branch
from
pr440
base: 519-policy-api-updates
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhilto
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things:
- Sorry this wasn't detailed in the issued, but for consistency with ScubaGear, the parameters shouldn't be saved as a separate json file. They should be saved in the primary ScubaResults.json file, in the
Raw
section, under the sub-keyscuba_config
. - The Pylinter is reporting several issues that should be resolved before merging: https://github.com/cisagov/ScubaGoggles/actions/runs/11691841759/job/32559891620?pr=551
- There are several merge conflicts. I know @rlxdev offered to help with any merge conflicts, you might ask him for help if you need it. I'm happy to help as well.
- Please describe what testing you performed in the "Testing" section of the pull request description.
rlxdev
force-pushed
the
519-policy-api-updates
branch
from
January 9, 2025 20:36
484e88d
to
67abc58
Compare
…arguments data structure
@aormu Alden's comments still need to be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Save ScubaGoggles Parameters/config to JSON output.
Save configuration to a JSON file.
💭 Motivation and context
This enables users to review the parameters utilized to operate this tool in the future.
Save the parameters value in a JSON file.
Closes #440
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist