Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Drive Docs 6.1 Implementation Steps #560

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Updating Drive Docs 6.1 Implementation Steps #560

merged 4 commits into from
Jan 9, 2025

Conversation

mdueltgen
Copy link
Collaborator

🗣 Description

Updated implemetation steps to be accurate to google admin console.

Updates drive docs

💭 Motivation and context

Closes #549

🧪 Testing

N/A

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@mdueltgen mdueltgen added this to the Eel milestone Jan 8, 2025
@mdueltgen mdueltgen requested review from buidav and adhilto January 8, 2025 17:15
@mdueltgen mdueltgen self-assigned this Jan 8, 2025
adhilto
adhilto requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having step 2 with a really long path, could you split it into multiple steps? To be consistent with the other implementation instructions and I think it would be more user-friendly.

For example:
image

@mdueltgen mdueltgen requested a review from adhilto January 8, 2025 21:23
buidav
buidav requested changes Jan 9, 2025
View reviewed changes
scubagoggles/baselines/drive.md Outdated Show resolved Hide resolved
scubagoggles/baselines/drive.md Outdated Show resolved Hide resolved
@jkaufman-mitre jkaufman-mitre requested a review from buidav January 9, 2025 12:28
@adhilto adhilto merged commit a656c97 into eel Jan 9, 2025
8 of 10 checks passed
@adhilto adhilto deleted the 549-update-drivedocs-61-instructions branch January 9, 2025 14:38
adhilto pushed a commit that referenced this pull request Jan 9, 2025
@mdueltgen @jkaufman-mitre
@buidav @adhilto
Updating Drive Docs 6.1 Implementation Steps (#560)
90564ff 
* updating drive docs 6.1 implementation steps

* cleaning up steps for 6.1 implementations steps

* slight update/fixes

* Apply suggestions from code review

Co-authored-by: David Bui <[email protected]>

---------

Co-authored-by: jkaufman-mitre <[email protected]>
Co-authored-by: David Bui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhilto adhilto adhilto approved these changes

@buidav buidav buidav approved these changes

Assignees

@mdueltgen mdueltgen

Labels
Baseline Revision Drive_Docs
Projects
None yet
Milestone
Eel
Development

Successfully merging this pull request may close these issues.
4 participants
@mdueltgen @buidav @adhilto @jkaufman-mitre