Work Around Google's WORKSPACE_ALL_ADMIN_GROUP #578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Google is returning an actual group name,
WORKSPACE_ALL_ADMIN_GROUP
, in some cases as part of the policy API results. This does not conform to the documented format ofgroups/<group-id>
, and was causing the ScubaGoggles code to crash when encountering this unexpected value. Based on Google's response, a work-around has been put into place to "tolerate" non-conforming group values.Closes #572
🧪 Testing
This has been tested in the debugger by simulating the
WORKSPACE_ALL_ADMIN_GROUP
group value in the Google results, as our tenant (scubagws.org) does not currently return this value. The user who reported this issue also tested the proposed change and has confirmed that the change resolves the issue.✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist