Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work Around Google's WORKSPACE_ALL_ADMIN_GROUP #578

Draft
wants to merge 1 commit into
base: 519-policy-api-updates
Choose a base branch
from

Conversation

rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Jan 24, 2025

🗣 Description

Google is returning an actual group name, WORKSPACE_ALL_ADMIN_GROUP, in some cases as part of the policy API results. This does not conform to the documented format of groups/<group-id>, and was causing the ScubaGoggles code to crash when encountering this unexpected value. Based on Google's response, a work-around has been put into place to "tolerate" non-conforming group values.

Closes #572

🧪 Testing

This has been tested in the debugger by simulating the WORKSPACE_ALL_ADMIN_GROUP group value in the Google results, as our tenant (scubagws.org) does not currently return this value. The user who reported this issue also tested the proposed change and has confirmed that the change resolves the issue.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev self-assigned this Jan 24, 2025
@prodjom prodjom added this to the Driftwood milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants