Update DNSTwist to use the pe-reports module and run on all P&E orgs #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthew-Grayson
requested review from
Matthew-Grayson,
epicfaace and
lfilip-ivaal
and removed request for
epicfaace,
Matthew-Grayson and
lfilip-ivaal
epicfaace
reviewed
Jun 20, 2023
| @@ -14,6 +14,7 @@ const PE_DATA_SCHEMA = ` | |||
| -- Draft Database Schema to store scan data | |||
| -- Includes Domain Masquerading, Credentals Exposed, Inffered Vulns, and Dark Web data | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
What was this change for? Needed for dnstwist?
There was a problem hiding this comment.
Ya, these changes are needed to run dnstwist in the development environment:
- P&Es latest database schema
- Added sample organizations and domains
| } | ||
| } | ||
| const child = spawnSync('python', ['-m', 'pe_source', 'dnstwist'], { | ||
| stdio: 'inherit', |
There was a problem hiding this comment.
We should remove dnstwist from dockerfile
|
Waiting on pe-source module updates so we can install that inside the worker container instead of pe-reports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1968
🗣 Description
The DNSTwist scan was updated to run the dnstwist module in the pe-reports repository instead of the typescript implementation.
It is now global and will run on all P&E orgs marked report_on in the P&E organizations table. No vulnerability data will be stored in the Crossfeed database; only the P&E database intstance.
🧪 Testing
To test locally:
Follow normal steps in https://docs.crossfeed.cyber.dhs.gov/dev/quickstart/ with the addition of running:
Create and run a dnstwist scan from the frontend.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist