#3402: Portfolio and domain invitation updates [HOTGOV] #3428
+262
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-kennedy-ecs
requested review from
lizpearl,
therealslimhsiehdy,
Matt-Spence,
CocoByte,
Katherine-Osos,
erinysong,
asaki222,
zandercymatics and
a team
|
🥳 Successfully deployed to developer sandbox hotgov. |
src/registrar/admin.py
Outdated
| has_errors = any(message.level_tag in ["error", "warning"] for message in storage) | ||
| has_errors = any(message.level_tag in ["error"] for message in storage) |
There was a problem hiding this comment.
errors are blocking and warnings are not, so need to be handled differently
Comment on lines
-73
to
+79
| messages.warning(request, str(exception)) | ||
| messages.error(request, str(exception)) | ||
| elif isinstance(exception, AlreadyDomainInvitedError): | ||
| messages.warning(request, str(exception)) | ||
| messages.error(request, str(exception)) | ||
| elif isinstance(exception, IntegrityError): | ||
| messages.warning(request, f"{email} is already a manager for this domain") | ||
| messages.error(request, f"{email} is already a manager for this domain") | ||
| else: | ||
| logger.warning("Could not send email invitation (Other Exception)", exc_info=True) | ||
| messages.warning(request, "Could not send email invitation.") | ||
| messages.error(request, "Could not send email invitation.") |
There was a problem hiding this comment.
errors that block functions are errors, warning that allow functionality to continue are warnings
|
🥳 Successfully deployed to developer sandbox hotgov. |
|
🥳 Successfully deployed to developer sandbox hotgov. |
CocoByte
reviewed
Jan 30, 2025
|
🥳 Successfully deployed to developer sandbox hotgov. |
CocoByte
approved these changes
Jan 31, 2025
|
🥳 Successfully deployed to developer sandbox hotgov. |
|
🥳 Successfully deployed to developer sandbox hotgov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #3402
Resolves #3378
Resolves #3401
Resolves #3403
Changes
Context for reviewers
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots