+errorReport #34
Merged
+errorReport #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhirafovod
approved these changes
Dec 19, 2023
| const key = metaInfo.jsonPointer__ as string; | ||
| if(this.errorReport[key] === undefined){ | ||
| this.errorReport[key] = error; | ||
| }else if (Array.isArray(this.errorReport[key])){ |
There was a problem hiding this comment.
Do you want to cover these cases with a test?
| @@ -31,7 +31,7 @@ export default class CliCore { | |||
| constructor(templateProcessor: TemplateProcessor = null) { | |||
| this.templateProcessor = templateProcessor; | |||
| this.logLevel = "info"; | |||
| this.currentDirectory = path.join(process.cwd(), 'example'); // Default to cwd/example | |||
| this.currentDirectory = process.cwd(); | |||
There was a problem hiding this comment.
I think defaulting to example directory was quite good experience for most cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#31
adds $errorReport function
Type of Change
Checklist