CI Cleanup #400
Closed
CI Cleanup #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glhewett
approved these changes
Oct 27, 2023
.github/workflows/main_ci.yml
Outdated
| VCPKG_REPO: ${{ github.workspace }}/vcpkg | ||
| CACHE_VERSION: v01 | ||
| CACHE_NAME: vcpkg | ||
|
|
||
| OPENSSL_11_VCPKG: alternatives/openssl_1.1 | ||
| OPENSSL_3_VCPKG: alternatives/openssl_3 | ||
| BORINGSSL_VCPKG: alternatives/boringssl |
There was a problem hiding this comment.
I find myself getting confused about which vcpkg attribute we might be talking about. I would recommend renaming this to *_VCPKG_MANIFEST to match the cmake option.
.github/workflows/main_ci.yml
Outdated
| @@ -196,7 +215,7 @@ jobs: | |||
| runs-on: macos-latest | |||
|
|
|||
| env: | |||
| CMAKE_BUILD_DIR: ${{ github.workspace }}/build | |||
| BUILD_DIR: ${{ github.workspace }}/build | |||
| VCPKG_BINARY_SOURCES: files,${{ github.workspace }}/build/cache,readwrite | |||
There was a problem hiding this comment.
I know you did not change anything, but this is redundant. It should be at the top.
glhewett
reviewed
Oct 27, 2023
There was a problem hiding this comment.
I think it would be wise to have a default vcpkg.json in the root of the project. Not because it is useful but because it what people expect.
Alternatively, when we add the build directions, we can request the user to copy or symlink the file. We might want to add it to the .gitignore if that is the case.... just a brainstorm
|
Closed in favor of #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of small fixes to make CI more rational / elegant:
vcpkg-dirvariablesDepends on #398