Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h/v-lines: increase final dilation along major axis #61

Merged

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Aug 20, 2020

Fix #59

@finkf please don't merge yet! I'll try to aggregate more useful fixes for h/v-line detection here (which is crucial for segmentation, but still has lots of potential when compared with the recipes in Tesseract). Also, this can serve as a testbed for others for the time being.

@bertsky bertsky added the enhancement New feature or request label Aug 20, 2020
- cover zero area intersections,
  treating them like empty
- cover heterogeneous intersections,
  removing zero area shapes
- cover invalid paths on the input or output side
  (from rounding) via repeated simplification
- cover invalid paths which cannot be repaired
  through simplification directly
  (find a new starting point in the point sequence)
- update shapely
@bertsky
Copy link
Collaborator Author

bertsky commented Sep 14, 2020

Fix #62 #67

@bertsky
Copy link
Collaborator Author

bertsky commented Sep 14, 2020

@finkf I won't be revisiting the h/v-line detection any time soon, so I bundled that tiny change with a number of fixes improving robustness (parallel to our current problems with Shapely in other modules). In anticipation of your approval, I increased the version number once again.

When we merge, we should avoid squashing.

@bertsky bertsky merged commit c361dbb into cisocrgroup:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants