Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

et-al-min has to be greater than et-al-use-first #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

georgd
Copy link
Contributor

@georgd georgd commented Apr 27, 2021

Stumbling upon this twice in a PR today I couldn’t find this restraint neither in the schema (I wouldn’t know how to express it there) nor in the documentation.

Stumbling upon this twice in a PR today I couldn’t find this restraint neither in the schema (I wouldn’t know how to express it there) nor in the documentation.
@bdarcus
Copy link
Member

bdarcus commented Apr 27, 2021

Stumbling upon this twice in a PR today I couldn’t find this restraint neither in the schema (I wouldn’t know how to express it there)

Pretty sure you need to use schematron for that. The existing sch schema should give some ideas, if you'd like to give it a try.

@georgd
Copy link
Contributor Author

georgd commented Apr 27, 2021

Stumbling upon this twice in a PR today I couldn’t find this restraint neither in the schema (I wouldn’t know how to express it there)

Pretty sure you need to use schematron for that. The existing sch schema should give some ideas, if you'd like to give it a try.

I just looked into the existing files in the schema repo and couldn’t find a hint about that. But my knowledge of the whole schema thing is all but profound.

@bdarcus
Copy link
Member

bdarcus commented Apr 27, 2021

If other reviewers approve the substantive change, we can add the logic to the schema, which is here:

https://github.com/citation-style-language/schema/blob/master/schemas/styles/csl.sch

Copy link
Member

@bwiernik bwiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format this change as one-sentence-per-line rather than 80-characters-per-line.

I don't see a problem with this. It doesn't impact processors at all as far as I can see because it is just a restriction on valid styles from the schema side. I think this could be merged as a bug fix into CSL 1.0.2 after the schema is correspondingly updated.

@bdarcus
Copy link
Member

bdarcus commented Apr 27, 2021

Please format this change as one-sentence-per-line rather than 80-characters-per-line.

This document isn't currently formatted that way.

I'll see if I can find a script to automate the conversion.

@bwiernik
Copy link
Member

Yes, but we have started in a few places to add new additions that way to reduce later changes.

@bdarcus
Copy link
Member

bdarcus commented Apr 28, 2021

Yes, but we have started in a few places to add new additions that way to reduce later changes.

Ah.

I experimented a bit, and concluded a completely automated solution isn't practical.

This, OTOH, if you use Emacs (I imagine other editors may have similar), is awesome!

https://emacs.stackexchange.com/a/473

@georgd
Copy link
Contributor Author

georgd commented Apr 28, 2021

But that won't give you a line per sentence, would it?

I was almost through when I remarked I was in the wrong branch...

@bdarcus
Copy link
Member

bdarcus commented Apr 28, 2021

But that won't give you a line per sentence, would it?

Yes; the fill-paragraph command converts this:

One line per
sentence.

One line. Per sentence.

... to this:

One line per sentence.
One line.
Per sentence.

@denismaier
Copy link
Member

Will this work with one space after a period as well? Or do you need two spaces? Will it convert "Mrs. Smith said ..." to:

Mrs. Smith said ...
Or.:
Mrs.
Smith said ...

?

@bdarcus
Copy link
Member

bdarcus commented Apr 28, 2021

Will this work with one space after a period as well?

No, it's not very smart as is.

But I wouldn't run this on an entire file; more paragraph-by-paragraph, or region-by-region.

It still simplifies the process.

@bwiernik
Copy link
Member

I might also try using RStudio's editor, which has a function to convert between 80 spaces/sentence. It seems to be fairly smart.

@bwiernik
Copy link
Member

@georgd Could you submit this change as a PR to the schema repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants