Update docker images #4122
Update docker images #4122
Conversation
SaitTalhaNisanci
force-pushed
the
update_docker_images
branch
4 times, most recently
from
dde5522 to
cbe185a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4122 +/- ##
==========================================
- Coverage 90.76% 88.20% -2.56%
==========================================
Files 187 186 -1
Lines 36201 35888 -313
==========================================
- Hits 32858 31656 -1202
- Misses 3343 4232 +889 |
SaitTalhaNisanci
force-pushed
the
update_docker_images
branch
9 times, most recently
from
8d26d63 to
2e2a0ff
Compare
SaitTalhaNisanci
force-pushed
the
update_docker_images
branch
2 times, most recently
from
3f9d4df to
618f105
Compare
| - persist_to_workspace: | ||
| root: . | ||
| paths: | ||
| - build-11/* |
There was a problem hiding this comment.
if we checkout at every stage, does this still need to be in the workspace?
There was a problem hiding this comment.
Yeah because we use this folder for running the tests:
There was a problem hiding this comment.
Is there a technical reason we can't run from the checkout?
There was a problem hiding this comment.
technically I think we should be able to do that. As far as I remember Makefile in build-X is already a symbolic link to src/.../Makefile so I am guessing that it should work but that is something to try. I would suggest trying that when updating pg-13 image from 13beta3 to 13.0, what do you think? I can create an issue for trying that on the-process repo.
There was a problem hiding this comment.
The build image was a single one and it would contain pg11, pg12 and pg13. Now it is separated so that we can build each pg major independently. Tags are used as full postgres versions so that we can know which version we use by looking at the tag. For example exttester:11.9 would mean we are using pg11.9. pg11 is updated from 11.5 to 11.9. pg12 is updated from 12rc to 12.4.
SaitTalhaNisanci
force-pushed
the
update_docker_images
branch
from
743fcff to
023dfdf
Compare
The build image was a single one and it would contain pg11, pg12 and
pg13. Now it is separated so that we can build each pg major
independently.
Tags are used as full postgres versions so that we can know which
version we use by looking at the tag. For example exttester:11.9 would
mean we are using pg11.9.
pg11 is updated from 11.5 to 11.9.
pg12 is updated from 12rc to 12.4.
pg13 is updated to 13beta3.
Ones the general structure is "approved", the repos will be updated as
citusfromheisenberg302.