-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Scan (ColumnarScan): exclude outer_join_rels from CandidateRelids #7703
base: release-13.0
Are you sure you want to change the base?
Conversation
@OlgaSergeyevaB Olga, thanks for PR. You can take the tests from here.
|
here is also one fix for distributed case |
|
@ivan-v-kush, thanks for your tests. But its fall without sorting. |
@microsoft-github-policy-service agree |
@OlgaSergeyevaB thank you for submitting this PR. Can you rebase it to the release-13.0 branch ? We would like to include this in Citus' next patch release. |
@colm-mchugh , I rebase it to the release-13.0 branch |
Can you squash your commits into 1 commit ? Then we can review. Thanks @OlgaSergeyevaB . |
@colm-mchugh, I squash my commits into 1 commit. Thanks @colm-mchugh |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (72.94%) is below the target coverage (87.50%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7703 +/- ##
=================================================
- Coverage 89.48% 72.94% -16.55%
=================================================
Files 276 276
Lines 60063 59873 -190
Branches 7524 7505 -19
=================================================
- Hits 53747 43673 -10074
- Misses 4166 13482 +9316
- Partials 2150 2718 +568 |
@m3hm3t @naisila the fix in this PR looks good to me but I don't understand why codecov is failing - do you know what can we or the PR author do to have it go green ? |
@colm-mchugh , maybe I should add another test test |
@colm-mchugh We can ignore that since I believe it doesn't take into account commits that are not part of the repository, but rather belong to a fork. I was looking at other community contributions to Citus, and in many cases codecov failed.
@OlgaSergeyevaB even though codecov would still fail, please do include an EXPLAIN query, seems useful. Thanks! I am approving the PR as well. |
@@ -1051,6 +1051,11 @@ FindCandidateRelids(PlannerInfo *root, RelOptInfo *rel, List *joinClauses) | |||
|
|||
candidateRelids = bms_del_members(candidateRelids, rel->relids); | |||
candidateRelids = bms_del_members(candidateRelids, rel->lateral_relids); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment here for the relevant PG16 commit requiring this addition:
postgres/postgres@2489d76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naisila , I add comment
Thanks, sounds like a reasonable explanation, I've approved also.
Yes @OlgaSergeyevaB +1 for the test. The EXPLAIN output might differ with different PG versions, but let's see. |
@naisila, @colm-mchugh , I add test |
…s from CandidateRelids For the relevant PG16 commit requiring this addition: * postgres/postgres@2489d76 Add test from https://github.com/hydradatabase/hydra/pull/279/files add order by for test and add explain
DESCRIPTION: Fixes a crash in columnar custom scan that happens when a columnar table is used in a join.
Fixes #7647.