Improve & simplify valgrind testing #278
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_cluster.sh
and its friends can still be used to create an Azure VM but they are not a must now. See the changes in README.md for more details.Note to reviewer - although the PR touches nine files, this PR mainly introduces following three files and updates the README on the usage of valgrind testing infra. The other 5 files are only modified to remove the old infra.
The dockerfile to build a simple docker image that can be used to run valgrind tests.
This has nothing but Postgres & Citus built with the flags that are needed to properly run valgrind tests and valgrind itself.
The script that we run within the container to run the valgrind test for the specified test schedule.
We could set the entrypoint of the container to this script but we keep it as a separate script for simplicity.
The host side script that we use to build the container and run the valgrind tests through the container.
I strongly recommend reading the relevant section of the README from this PR to better understand the changes.