-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 16beta3 CI images #135
Conversation
1dc71bf
to
681a6a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the regression tests on Citus pass without wal2json packages?
@hanefi I forgot to convert this to draft PR. However I am using this current PR to run the other PG16 tests in my branch. |
b167ba6
to
ca85221
Compare
ca85221
to
c55d02b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution. I have only one suggestion that can reduce docker layer cache sizes.
An excerpt from Dockerfile best practices on apt-get section :
I learned quite a lot from this piece of documentation about how docker works, and I recommend others to read that as well. |
9839f12
to
24c3474
Compare
24c3474
to
96db5c2
Compare
96db5c2
to
dbbac7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good except a small spacing issue
Co-authored-by: Hanefi Onaldi <[email protected]>
wal2json
is needed for cdc tests, so we certainly can't merge like this. Last yearwal2json
support for pg15 was provided in July. Let's wait a bit before deciding on this.However I am using this current PR to run the other PG16 tests in my branch of PG16 support PR