Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 16beta3 CI images #135

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Add 16beta3 CI images #135

merged 5 commits into from
Aug 17, 2023

Conversation

naisila
Copy link
Member

@naisila naisila commented Jun 5, 2023

wal2json is needed for cdc tests, so we certainly can't merge like this. Last year wal2json support for pg15 was provided in July. Let's wait a bit before deciding on this.

However I am using this current PR to run the other PG16 tests in my branch of PG16 support PR

@naisila naisila requested a review from hanefi June 5, 2023 07:57
@naisila naisila force-pushed the naisila/add-pg16beta1 branch 2 times, most recently from 1dc71bf to 681a6a2 Compare June 5, 2023 11:04
naisila added a commit to citusdata/citus that referenced this pull request Jun 5, 2023
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the regression tests on Citus pass without wal2json packages?

@naisila
Copy link
Member Author

naisila commented Jun 5, 2023

@hanefi I forgot to convert this to draft PR. wal2json is needed for cdc tests, so we certainly can't merge like this. Last year wal2json support for pg15 was provided in July. Let's wait a bit before deciding on this.

However I am using this current PR to run the other PG16 tests in my branch.

@naisila naisila marked this pull request as draft June 5, 2023 13:01
naisila added a commit to citusdata/citus that referenced this pull request Jun 5, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 6, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 6, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 6, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 6, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 6, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 7, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 7, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 7, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 7, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 7, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 8, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 8, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 8, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 8, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 9, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 9, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 9, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 14, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 14, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 14, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 14, 2023
naisila added a commit to citusdata/citus that referenced this pull request Jun 14, 2023
@naisila naisila force-pushed the naisila/add-pg16beta1 branch from b167ba6 to ca85221 Compare August 15, 2023 10:40
@naisila naisila changed the title Add 16beta2 CI images Add 16beta3 CI images Aug 15, 2023
naisila added a commit to citusdata/citus that referenced this pull request Aug 15, 2023
naisila added a commit to citusdata/citus that referenced this pull request Aug 16, 2023
naisila added a commit to citusdata/citus that referenced this pull request Aug 16, 2023
naisila added a commit to citusdata/citus that referenced this pull request Aug 16, 2023
naisila added a commit to citusdata/citus that referenced this pull request Aug 17, 2023
@naisila naisila force-pushed the naisila/add-pg16beta1 branch from ca85221 to c55d02b Compare August 17, 2023 08:26
naisila added a commit to citusdata/citus that referenced this pull request Aug 17, 2023
naisila added a commit to citusdata/citus that referenced this pull request Aug 17, 2023
@naisila naisila requested a review from hanefi August 17, 2023 09:16
@naisila naisila marked this pull request as ready for review August 17, 2023 11:09
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution. I have only one suggestion that can reduce docker layer cache sizes.

naisila added a commit to citusdata/citus that referenced this pull request Aug 17, 2023
@hanefi
Copy link
Member

hanefi commented Aug 17, 2023

An excerpt from Dockerfile best practices on apt-get section :

... when you clean up the apt cache by removing /var/lib/apt/lists it reduces the image size, since the apt cache isn’t stored in a layer. Since the RUN statement starts with apt-get update, the package cache is always refreshed prior to apt-get install.

I learned quite a lot from this piece of documentation about how docker works, and I recommend others to read that as well.

@naisila naisila requested a review from hanefi August 17, 2023 14:06
@naisila naisila force-pushed the naisila/add-pg16beta1 branch from 9839f12 to 24c3474 Compare August 17, 2023 14:14
@naisila naisila removed the request for review from hanefi August 17, 2023 14:21
@naisila naisila force-pushed the naisila/add-pg16beta1 branch from 24c3474 to 96db5c2 Compare August 17, 2023 14:26
@naisila naisila force-pushed the naisila/add-pg16beta1 branch from 96db5c2 to dbbac7e Compare August 17, 2023 14:30
@naisila naisila requested a review from hanefi August 17, 2023 14:33
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good except a small spacing issue

@naisila naisila merged commit 0c8d80c into master Aug 17, 2023
naisila added a commit to citusdata/citus that referenced this pull request Aug 17, 2023
@naisila naisila deleted the naisila/add-pg16beta1 branch September 15, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants