Feat: add dtype selection to PixArt #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
city96
reviewed
Jan 26, 2024
city96
reviewed
Jan 26, 2024
city96
reviewed
Jan 26, 2024
|
type annotations removed |
|
Thanks, looks good now. I thought about it more and I might be able to get FP8 support working for just the PixArt model. I'll take a shot at it tonight or tomorrow, then merge this if that doesn't pan out. |
|
Alright, I got started on proper FP8 support on this branch. I think it's doable, though I don't have much free time these days. In the meantime I just added a quick workaround so the current code still works when launched with |
|
Fine, I'll test it afterwards |
|
The quick fix works fine, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dtype selection to pixart loading so that it won't conflicting with fp8 mode of ComfyUI, which is incompatible with pixart models mentioned in #9