Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates_atd_project_owner_to_tpw_project_owner #1519

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

tillyw
Copy link
Contributor

@tillyw tillyw commented Jan 2, 2025

Associated issues

fixes cityofaustin/atd-data-tech#20178

this pr does some additional cleanup to the Moped database to reflect the departmental reorganization

Testing

URL to test:

local because database changes

Steps to test:

  • apply migrations to your local db and spin up a db client using prod data
  • check in moped_project_roles that the 'ATD Project Owner' role has been renamed to 'TPW Project Owner'
  • check the 'Inspector' project role description to confirm 'ATD' was changed to 'TPW'
  • check that there is no longer an 'Unknown Role' with project_role_id = 0 (I confirmed that there were no references to this record in moped_proj_personnel_roles)
  • in Moped, go to a project's team table and confirm the table displays without error (I removed the filter in TEAM_QUERY for project_role_id greater than 0, the only instance of this filter in the app)
  • edit a record and select the 'Project role' dropdown to confirm there is no 'Unknown Role' option
  • run the down migration and check that the changes are reverted, with 'TPW' becoming 'ATD' in both cases above and the 'Unknown Role' record and dropdown option reappearing

Ship list

Copy link
Member

@johnclary johnclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test steps check out. Looks great to me! 🚢 🚢 🚢

Copy link
Collaborator

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thanks! 🚢 🙌 🚢

Copy link
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye bye atd

Copy link
Contributor

@roseeichelmann roseeichelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great tilly!

Copy link
Member

@frankhereford frankhereford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting another record with id = 0 out of there! 🙏 🚢

@mddilley
Copy link
Collaborator

thanks again @tillyw!!! merging this to start testing this morning 🧪

@mddilley mddilley merged commit 3365e3a into main Jan 16, 2025
5 checks passed
@mddilley mddilley deleted the 20178_update_atd_product_owner_role_to_tpw branch January 16, 2025 15:59
@mateoclarke
Copy link
Contributor

Late to the party but this all worked as described for me! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ATD Product Owner role to TPW Product Owner in roles table
7 participants