Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - Add action modes for joins #31480

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 14, 2024

Overview

Adds an "Allowed Actions" setting for joined records (e.g. Phone, Email, Multi-value custom) in Afform
Fixes dev/core#5589
Replaces #31477

Before

The main entity supports lets you enable/disable actions, but not the joined entities (email, address, phone, multi-record custom data). Those are currently set to allow create+update+delete.

image

After

Can disable update & delete actions if desired (if both are unchecked, only create is allowed).

Screenshot 2024-11-14 at 11 19 35 AM

Copy link

civibot bot commented Nov 14, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@colemanw colemanw marked this pull request as ready for review December 16, 2024 21:05
@colemanw colemanw changed the title Afform - WIP action modes for joins Afform - Add action modes for joins Dec 16, 2024
@devdavc
Copy link
Contributor

devdavc commented Dec 18, 2024

@colemanw Thank you so much. I really appreciate you taking your time for this. Everything is great. Thank you again.

@monishdeb
Copy link
Member

I have tested this in local m/c and confirmed that the new actions does apply on joined entities. And has a test. Merging now!

@monishdeb monishdeb merged commit 794daaa into civicrm:master Dec 20, 2024
1 check passed
@colemanw colemanw deleted the afformActionMode branch December 20, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants