dev/core#5629 - case activity send copy has blank details on the email activity filed on the case

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/5629

Before

In 5.71, the case activity message template text version was blanked out. While the sending of the actual email converts the html to text, the code that files the email on the case as an activity never gets a copy of that conversion, so was filing the blanked out text.

After

I chose option 2a, to just use the html. Besides looking nicer when viewing the activity, it's an easier code update.

Technical Details

Comments

This is a little hard to test on the PR test site since it locks outbound mail down to smtp which fails. You used to be able to set it to Redirect to Database and then actions wouldn't fail and you could view it under Archived Mailings. But here's a partial screenshot of what it looks like on my local:

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5629