Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering by event type in eventlisting Joomla page #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

webmaster-cses-org-uk
Copy link
Contributor

This simple change allows an event page to have a filter on event type, which is already provisioned for in CRM_Event_Page_List.

This has proved very useful in our use case.

Tested and working on our CiviCRM installation for over a year now.

This simple change allows an event page to have a filter on event type, which is already provisioned for in CRM_Event_Page_List.

This has proved very useful in our use case.
@mlutfy
Copy link
Member

mlutfy commented Nov 4, 2021

Thanks @webmaster-cses-org-uk ! I'm not too familiar with Joomla, and hopefully other Joomla folks can chime in, but could you explain a bit what the change does? Is there any change in existing functionality?

@webmaster-cses-org-uk
Copy link
Contributor Author

Hi @mlutfy yes of course, apologies. This change adds a field to the Joomla configuration page when setting up the menu item, as shown in the screenshot below. If populated, Joomla automatically adds the "type" field to the URL, which is processed in CRM_Event_Page_List::run().

image

Ideally this could be loaded with a dropdown populated with the event type pseudoconstant, but is a quick way to achieve this functionality to begin with.

There is no change to existing functionality: if this field is left empty, behaviour is as currently i.e. no filtering.

Likewise, there is no need to change anything in existing installations: Joomla only updates the menu URL when the form is submitted (the fields specified in the XML are only used to build the URL when the menu item is saved, and are not used 'live' in any way).

Hope that helps, let me know if you need anything else.

For consistency with surrounding items.
@thoni56
Copy link
Contributor

thoni56 commented Jan 2, 2024

This is an interesting PR. I would like to see it merged. Possibly with the dropdown @webmaster-cses-org-uk suggested but I don't know how complicated it is to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants