Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix issue where by using the i18n translation form with RichTex… #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seamuslee001
Copy link
Contributor

…tEditor widgets was causing data to be escpaed in the database

@demeritcowboy I believe this resolves your testing issue found here civicrm/civicrm-core#26135

The problem being is that the data is being escaped as part of exportValues before being sent into the database because by default the widgets have a collapsed class added here https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/I18n/Form.php#L79 as well as the wysiwyg class here https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Form.php#L476 which means that this if statement returns false for them

ping @mlutfy

@civibot
Copy link

civibot bot commented May 1, 2023

(Standard links)

…tEditor widgets was causing data to be escpaed in the database
@seamuslee001 seamuslee001 force-pushed the i18n_double_escape_wysiwyg branch from a380645 to ca4d1b6 Compare May 1, 2023 23:54
@demeritcowboy
Copy link
Contributor

demeritcowboy commented May 2, 2023

The other PR was merged. Not sure what you want to do with this one. The fails are real but is just because it should be ?? '' not ?? []. The upgrade fails are maybe something about the test config in this repo - like it needs updating after the recent core PR that upped the minimum version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants