CIVIMM-249: UI Improvements on compuclient 7.x-4.0 (CiviCRM - 5.75) upgrade #567
Conversation
swastikpareek
force-pushed
the
CIVIMM-249-ui-improvements-after-civi-5.75-upgrade
branch
from
d02cb1d to
59b346e
Compare
swastikpareek
force-pushed
the
CIVIMM-249-ui-improvements-after-civi-5.75-upgrade
branch
from
59b346e to
062b949
Compare
swastikpareek
force-pushed
the
CIVIMM-249-ui-improvements-after-civi-5.75-upgrade
branch
from
062b949 to
547e9e9
Compare
| @@ -1,3 +1,4 @@ | |||
| //stylelint-disable selector-max-compound-selectors, max-nesting-depth, selector-max-id | |||
There was a problem hiding this comment.
@swastikpareek Question do we need to disable these selectors? if now can we remove these stylints?
There was a problem hiding this comment.
Moving ahead, we will be planning to get rid of this theme and styles anyways, as the CiviCRM is doing a branch new version https://civicrm.org/blog/josh/announcing-civicrm-6 CIVICRM 6 and we will use the new theme framework riverlea to base our new shoreditch-theme (at least that's the plan for now as per my discussion with @jamienovick)
So, I suggest that we only touch the CSS files we need to fix. Also, removing selector-max-compound-selectors, max-nesting-depth, selector-max-id stylelint rules from the global configuration can open the doors for other developers to go crazy and write any CSS selector they want. And we shouldn't allow that, if we want to disable specific rules for specific files, we can disable them as per the files.
Hope that answers your question.
Overview
This PR adds basic CSS to improve UI styles of the CiviCRM pages after CiviCRM - 5.75 raised by Jamie on https://compucorp.atlassian.net/wiki/spaces/CN/pages/4682776583/Compuclient+4.0+upgrade+-+UI+Shoreditch+issues document.
Before/After
Technical Details
Most changes were done using plain CSS adjustments. The accordion header styles were taken (and improved) from #565 since that PR was very old, reviewing and expecting the author to update the changes will be time-consuming, so we decided to copy the changes in our PR.
Backstop JS Report
I have tried running the backstop test suite, but some screens of the backstop test suite seem incompatible with the new Civic screens and therefore, I didn't bother to run the whole suite and just ran basic scenario groups - like events, contributions, contacts and administration screens.
All the failed scenarios were related to the spacing and restyling of accordions we did.